From 10f446f1b2297fee8b22a35dd1f9d8da2a95db20 Mon Sep 17 00:00:00 2001 From: Stephen Gordon Date: Wed, 15 Nov 2023 14:36:47 -0600 Subject: [PATCH 1/3] fixed typo in documentation --- docs/resources/org_cloud_account_v2.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/resources/org_cloud_account_v2.md b/docs/resources/org_cloud_account_v2.md index d5237dc3..e9ec636e 100644 --- a/docs/resources/org_cloud_account_v2.md +++ b/docs/resources/org_cloud_account_v2.md @@ -239,7 +239,7 @@ Before onboarding the aws cloud account `external_id` for account must be genera ### `Step 1`: Fetch the supported features. Refer **[Supported features readme](https://registry.terraform.io/providers/PaloAltoNetworks/prismacloud/latest/docs/data-sources/cloud_account_supported_features)** for more details. ```hcl -data "prismacloud_account_supported_features" "prismacloud_supported_features" { +data "prismacloud_account_supported_features" "prismacloud_supported_features_tenant" { cloud_type = "azure" account_type = "tenant" deployment_type = "azure" From ca95a3d85b8731c8fb4a6560ddbf5d64d11850e9 Mon Sep 17 00:00:00 2001 From: Stephen Gordon Date: Wed, 15 Nov 2023 16:28:58 -0600 Subject: [PATCH 2/3] rename file to match resource name --- ...ccount_supported_features.md => account_supported_features.md} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename docs/data-sources/{cloud_account_supported_features.md => account_supported_features.md} (100%) diff --git a/docs/data-sources/cloud_account_supported_features.md b/docs/data-sources/account_supported_features.md similarity index 100% rename from docs/data-sources/cloud_account_supported_features.md rename to docs/data-sources/account_supported_features.md From 52bda5659946a25b8ac4d203a9a646ab7ea1486f Mon Sep 17 00:00:00 2001 From: Stephen Gordon Date: Wed, 15 Nov 2023 19:26:41 -0600 Subject: [PATCH 3/3] add tenantWithMgmt as Azure type --- docs/data-sources/account_supported_features.md | 2 +- prismacloud/data_source_cloud_account_supported_features.go | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/data-sources/account_supported_features.md b/docs/data-sources/account_supported_features.md index 14ec50ab..17d1dcbc 100644 --- a/docs/data-sources/account_supported_features.md +++ b/docs/data-sources/account_supported_features.md @@ -28,7 +28,7 @@ output "features_supported" { The following are the params that this data source supports: * `cloud_type` - (Required) Cloud type. `aws`, `azure`, or `gcp`. -* `account_type` - (Required) Cloud account type. `account`, `organization`, `masterServiceAccount`, or `tenant`. Supported values based on cloud_type are given below.
- account, organization - cloud_type: **aws**
- account, organization, masterServiceAccount - cloud_type: **gcp**
- account, tenant - cloud_type: **azure** +* `account_type` - (Required) Cloud account type. `account`, `organization`, `masterServiceAccount`,`tenantWithMgmt`, or `tenant`. Supported values based on cloud_type are given below.
- account, organization - cloud_type: **aws**
- account, organization, masterServiceAccount - cloud_type: **gcp**
- account, tenant, tenantWithMgmt - cloud_type: **azure** * `deployment_type` - (Optional) *Applicable only for cloud_type: **azure***. Possible values: `azure`, `azure_gov`, or `azure_china`.
- **azure** - Account type is commercial
- **azure_gov** - Account type is Government on Prisma Commercial and Government stacks.
- **azure_china** - Prisma China Stack. * `aws_partition` - (Optional) *Applicable only for Prisma Government Stack(**app.gov.prismacloud.io**) and given if the Cloud account Global Deployment option is enabled.
* - **us-east-1** - AWS Commercial/Global account.
- **us-gov-west-1** - AWS GovCloud account. * `root_sync_enabled` - (Optional) *Applicable only for cloud_type: **azure** and accountType: **tenant***.
In order to get supported features for accountType **tenant** and its associated **management groups** and **subscriptions**, rootSyncEnabled must be set to true. diff --git a/prismacloud/data_source_cloud_account_supported_features.go b/prismacloud/data_source_cloud_account_supported_features.go index 9f7e10e3..3d0c84b1 100644 --- a/prismacloud/data_source_cloud_account_supported_features.go +++ b/prismacloud/data_source_cloud_account_supported_features.go @@ -24,6 +24,7 @@ func dataSourceCloudAccountSupportedFeatures() *schema.Resource { "organization", "masterServiceAccount", "tenant", + "tenantWithMgmt", }, false, ),