Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/Compiler.php
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ public function convert(): string
public function convertNode(DOMNode $node, int $level = 0): DOMNode
{
if($node instanceof DOMComment){
$this->handleCommentNode($node);
return $node;
}
elseif($node instanceof DOMText){
Expand Down Expand Up @@ -750,4 +751,12 @@ protected function handleRootNodeClassAttribute($node) {
$node->setAttributeNode($attributeVClass);
return $node;
}

private function handleCommentNode(DOMComment $node)
{
$nodeValue = trim($node->nodeValue);
if (preg_match('/^(eslint-disable|@?todo)/i', $nodeValue) === 1) {
$node->parentNode->removeChild($node);
}
}
}
42 changes: 42 additions & 0 deletions tests/CommentNodeTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
<?php

namespace Paneon\VueToTwig\Tests;

class CommentNodeTest extends AbstractTestCase
{
public function testCommentNode()
{
$component = '<template><div><!-- info comment --></div></template>';
$expected = '<div class="{{class|default(\'\')}}"><!-- info comment --></div>';

$compiler = $this->createCompiler($component);

$actual = $compiler->convert();

$this->assertEqualHtml($expected, $actual);
}

public function testCommentNodeEslintDisable()
{
$component = '<template><div><!-- eslint-disable-next-line vue/no-v-html --></div></template>';
$expected = '<div class="{{class|default(\'\')}}"></div>';

$compiler = $this->createCompiler($component);

$actual = $compiler->convert();

$this->assertEqualHtml($expected, $actual);
}

public function testCommentNodeTodo()
{
$component = '<template><div><!-- todo change something --></div></template>';
$expected = '<div class="{{class|default(\'\')}}"></div>';

$compiler = $this->createCompiler($component);

$actual = $compiler->convert();

$this->assertEqualHtml($expected, $actual);
}
}