Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial support for signed messages #8198

Merged
merged 19 commits into from Aug 1, 2022
Merged

Initial support for signed messages #8198

merged 19 commits into from Aug 1, 2022

Conversation

Machine-Maker
Copy link
Member

@Machine-Maker Machine-Maker commented Jul 28, 2022 •
edited

Initial support for using signed, or signed+modified messages.

@Machine-Maker Machine-Maker requested a review from a team as a code owner July 28, 2022 04:17
@Machine-Maker
Copy link
Member Author

Machine-Maker commented Jul 28, 2022 •
edited

This does need some testing with chat plugins in more fleshed out environments. I'd appreciate anyone who wants to give feedback on these changes to download this jar, and try it out with your chat setup. Let me know here, or ping me in the Paper discord if you run into anything unexpected.

MiniDigger
MiniDigger previously approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@MiniDigger MiniDigger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good as a mvp, I like how relatively painless this is cause we already had most of the ground work done

@Machine-Maker Machine-Maker mentioned this pull request Jul 28, 2022
Closed
Owen1212055
Owen1212055 approved these changes Jul 29, 2022
View reviewed changes
Copy link
Member

@Owen1212055 Owen1212055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of testing was done between many other chat events and no issues seem to be present anymore.

@Machine-Maker Machine-Maker force-pushed the feature/signed-messages branch 2 times, most recently from 54f598a to d15ad22 Compare July 30, 2022 17:47
@Machine-Maker
Copy link
Member Author

Ok, I think this is pretty close to done. I've done some testing with various event interactions, and things work as expected.

@Machine-Maker Machine-Maker linked an issue Jul 30, 2022 that may be closed by this pull request
Component-based Preview Event #8201
Closed
kennytv
kennytv requested changes Jul 31, 2022
View reviewed changes
Copy link
Member

@kennytv kennytv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaks display name styling if the message content isn't changed; download EssX and use a nick/have an op prefix and it won't be displayed

kennytv
kennytv approved these changes Jul 31, 2022
View reviewed changes
Copy link
Member

@kennytv kennytv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Time to break everything

@Machine-Maker Machine-Maker merged commit dd3e4e7 into PaperMC:master Aug 1, 2022
1 check passed
@Machine-Maker Machine-Maker deleted the feature/signed-messages branch August 1, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Owen1212055 Owen1212055 Owen1212055 approved these changes

@kennytv kennytv kennytv approved these changes

@MiniDigger MiniDigger MiniDigger left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Component-based Preview Event
4 participants
@Machine-Maker @MiniDigger @Owen1212055 @kennytv