New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build configuration #3

Merged
merged 1 commit into from Oct 7, 2018

Conversation

Projects
None yet
3 participants
@DemonWav
Member

DemonWav commented Oct 5, 2018

This commit accomplishes several things:

  1. Converts the existing build script to Gradle Kotlin DSL
  2. Uses Gradle's new delayed configuration system
  3. Adds group and version properties, and other missing configs
  4. Switches from the maven plugin to the maven-publish plugin
  5. Adds some data to the generated pom.xml

Also un-ignores the gradle-wrapper.jar file and adds a .gitattributes file to prevent Git messing with gradlew.bat line endings.

Show resolved Hide resolved build.gradle.kts
Show outdated Hide outdated gradle/wrapper/gradle-wrapper.properties
Show outdated Hide outdated build.gradle.kts
Show outdated Hide outdated build.gradle.kts
repositories {
maven {
url = uri(repoUrl)

This comment has been minimized.

@Minecrell

Minecrell Oct 5, 2018

You could also write this as:

maven(repoUrl) {
    credentials {
        // ...
    }
}
@Minecrell

Minecrell Oct 5, 2018

You could also write this as:

maven(repoUrl) {
    credentials {
        // ...
    }
}

This comment has been minimized.

@DemonWav

DemonWav Oct 5, 2018

Member

I did it this way so I could give the repo a name, so the task description would be less ambiguous. I don't think there's a clean Kotlin DSL API for named repos.

@DemonWav

DemonWav Oct 5, 2018

Member

I did it this way so I could give the repo a name, so the task description would be less ambiguous. I don't think there's a clean Kotlin DSL API for named repos.

Fix build configuration
This commit accomplishes several things:

  1. Converts the existing build script to Gradle Kotlin DSL
  2. Uses Gradle's new delayed configuration system
  3. Adds group and version properties, and other missing configs
  4. Switches from the maven plugin to the maven-publish plugin
  5. Adds some data to the generated pom.xml

@DemonWav DemonWav merged commit ffdebcf into master Oct 7, 2018

@DemonWav DemonWav deleted the feature/gradle branch Oct 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment