Skip to content

feat(models): support optional clusterId param PS-15019 #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 25, 2020
Merged

feat(models): support optional clusterId param PS-15019 #324

merged 3 commits into from
Sep 25, 2020

Conversation

@bbatha
Copy link
Contributor

@bbatha bbatha commented Sep 21, 2020 •
edited
Loading

QA test plan (on Google SAML prod team):

pip install git+https://github.com/Paperspace/gradient-cli.git@feat-model-cluster-id
mkdir mymodel
gradient models download --id mos97714rseian9 --destinationDir mymodel
gradient models upload --modelType Tensorflow --name "test cluster model" --clusterId cljko0n9w mymodel
gradient deployments create --deploymentType TFServing --modelId <MODEL_ID> --name "test model upload" --imageUrl tensorflow/serving:2.1.0-gpu --clusterId cljko0n9w --machineType P4000 --instanceCount 1
gradient deployments start --id <DEPLOYMENT_ID>

@bbatha bbatha requested a review from robghchen September 21, 2020 18:43
tallyw00d
tallyw00d approved these changes Sep 25, 2020
View reviewed changes
Copy link

@tallyw00d tallyw00d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@bbatha bbatha merged commit 33b3c75 into master Sep 25, 2020
@bbatha bbatha deleted the feat-model-cluster-id branch September 25, 2020 16:28
@PSBOT
Copy link

PSBOT commented Sep 25, 2020

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@PSBOT PSBOT added the released label Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tallyw00d tallyw00d tallyw00d approved these changes

+1 more reviewer

@robghchen robghchen robghchen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bbatha @PSBOT @tallyw00d @robghchen