Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tsconfig to generate map and definition files #100

Merged
merged 25 commits into from Jun 12, 2019

Conversation

@hrharder
Copy link
Member

hrharder commented Jun 12, 2019

Overview

  • All TS projects now extend the tsconfig.json from @kosu/tsc-config
  • All TS projects now generate .map and .d.ts files to be included in published files.

Package @kosu/kosu.js

  • publish v0.1.0-alpha.7

Package @kosu/tsc-config

  • publish v0.1.0

Package @kosu/create-portal-helper

  • publish v0.1.0-alpha.8

Package @kosu/gov-portal-helper

  • publish v0.1.9

Package @kosu/system-contracts

  • publish v0.1.0-alpha.5
hrharder added 24 commits Jun 12, 2019
@hrharder

This comment has been minimized.

Copy link
Member Author

hrharder commented Jun 12, 2019

@Freydal CI seems to not be running all the tests, any ideas?

Even when I run yarn test locally, it only runs one of the kosu-system-contract tests. May have to do with not using relative paths for extending tsconfig.json files?

(Note the npm projects step only took 20 seconds... And the whole build only 3 minutes.)

@Freydal

This comment has been minimized.

Copy link
Contributor

Freydal commented Jun 12, 2019

I found a .only that got checked in. I removed it.

@hrharder

This comment has been minimized.

Copy link
Member Author

hrharder commented Jun 12, 2019

Awesome, thanks. I looked through the test files but must've missed it.

@hrharder hrharder merged commit 67bbcb6 into master Jun 12, 2019
1 check passed
1 check passed
continuous-integration/drone/pr Build is passing
Details
@hrharder hrharder deleted the refactor/generate-definition-files branch Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.