Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upgo-kosu: Use MultiStore #141
Conversation
This comment has been minimized.
This comment has been minimized.
|
Awesome! I will test this out today @gchaincl. Yesterday i was able to recreate the issue in the test-net with nodes not getting the same |
This comment has been minimized.
This comment has been minimized.
|
I believe I have fixed the rebalance issue (see Was able to get it to go up to ~10 in round number before I turned it off. I believe the issue was that all 4 rebalance transactions were getting executed instead of one, the reason being DeliverTx assumed all Tx's that passed CheckTx are still valid, even though they may not be. So by running CheckTx again before modifying the state, we can make sure the transaction from the mempool is still valid. @gchaincl I also set the initial round info in the Store during my debugging, and I'm not sure if that contributed to the fix, but I left it. Feel free to merge my branch in to this, or just add the additional checkTx call here. |
This comment has been minimized.
This comment has been minimized.
|
Great news! I remember I was checking it twice but then I removed it cause I thought it was duplicated. Thanks for finding the problem! |
gchaincl commentedJun 26, 2019
Overview
Use MultiStore engine from cosmos-sdk
Description
Replaces the state management using the right tool for the job +1
Some other minor changes are included here.