Addressing the linear growth of the reward rate

[Freydal]

Overview

Some time ago I realized the growth of the reward rate was linear. Reviewing some of the bonding info I decided it bothered me enough to be addressed.

Description

Testing instructions

Types of changes

• Refactor/enhancement
• Bug fix/behavior correction
• New feature
• Breaking change
• Other, additional

Notes

Status

• Prefix PR title with [WIP] if necessary (changes not yet made).
• Add tests to cover changes as needed.
• Update documentation/changelog as needed.
• Verify all tests run correctly in CI and pass.
• Ready for review/merge.

[Freydal]

I struggled with this for quite a while. I tried several methods of calculating the sqrt of the correctly. I finally thought to look at it a different way which is what it took for me to realize why my results were off.

Below is the results of 2 ether ^ 2 and 2 ether ^ 2 + 1.

The minimum for any whole number increase in the root would be greater than the maximum reward rate. This error may have contributed to the linear calculation that preceded it. I chose to simply add the root to the maximum for the time being. I think this was a temporary means of handling this calculation, but regardless this exercise was useful in opening my eyes to the calculation and dealing with numbers of this magnitude.

[hrharder]

Well sorry it's been such a headache.... I think the way you have it implemented now makes sense (at least for now) adding the sqrt of each new reward rate to the _maxGenerationSum.

Do you think this is ready to merge or are you still expanding/testing?

[Freydal]

I think it can be merged now.