Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upgo-kosu: make init a subcommand instead of a flag #191
+24
−15
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
hrharder commentedJul 26, 2019
Overview
Makes
--inita subcommand instead of a flag.For example to start a node:
# does both -- sometimes not wanted if we need to update config prior to start kosud --initRationale
There are cases where we want to initialize our directory (generate config and private keys) before we start the node. In the current implementation, the node can only be initialized if it is also started at the same time.
This way, we can generate our keys and config, and then update our config before we start the node. An example would be when setting up a production validator, we need to generate our keys and config before we start the node to set up the proper sentry infrastructure.
Notes