Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go kosu/integration against testnet #226

Merged
merged 26 commits into from Aug 27, 2019
Merged

Conversation

@gchaincl
Copy link
Contributor

gchaincl commented Aug 22, 2019

Overview

Rewrite of the integration test suite in order to use an existing/running testnet

Description

We needed to replace the previous test framework (Convey).
Tests are organized in such a way that each of them will run on a new block; subtests don't have that guarantee.

Testing instructions

We will need the Testnet endpoints and homedir path (we need the path in order to get the private keys).

The testnet parameter is configured using KOSU_TEST_NODES
KOSU_TEST_NODES is a comma-separated list of nodes following this format:
homedir1>[@url],... where:

  • is required and points to the node home directory
  • is optional and represents the node URL, if not specified it will take the url from config.RPC.ListenAddress

In my current setup, I start the testnet using make testnet and run the tests as follows:

 KOSU_TEST_NODES=$(pwd)/testnet/node0@localhost:8000,\
$(pwd)/testnet/node1@localhost:8001,\
$(pwd)/testnet/node2@localhost:8002,\
$(pwd)/testnet/node3@localhost:8003 go test ./tests/... -v -count=1 -run TestIntegrationTestSuite

Note that now the -tags=integration is not required, the test will be skipped if the KOSU_TEST_NODES has not been set.

gchaincl and others added 14 commits Aug 16, 2019
@gchaincl gchaincl force-pushed the go-kosu/integration-against-testnet branch 2 times, most recently from 594948f to 92fb51d Aug 22, 2019
@gchaincl gchaincl force-pushed the go-kosu/integration-against-testnet branch from 594948f to 92fb51d Aug 22, 2019
hrharder and others added 11 commits Aug 22, 2019
@gchaincl gchaincl requested a review from hrharder Aug 27, 2019
Copy link
Member

hrharder left a comment

Looks great. This is a really great improvement for the integration test suite! 🎉

@hrharder hrharder merged commit 67452b3 into master Aug 27, 2019
1 check passed
1 check passed
continuous-integration/drone/pr Build is passing
Details
@hrharder hrharder deleted the go-kosu/integration-against-testnet branch Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.