Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upRefactor/reviewing contract code and comments #234
Merged
Conversation
| @param eventType String name/type of event | ||
| @param data Bytes32 encoded data to be emitted from a centralized location | ||
| @param stringData String containing optional additonal information | ||
| /** @dev Emits a standard event from the Kosu contract system. The events can be decoded though the javascript library. |
This comment has been minimized.
This comment has been minimized.
hrharder
Aug 26, 2019
Member
Nit-picky: can we either say JavaScript (capitalization) or the Kosu.js library?
This comment has been minimized.
This comment has been minimized.
|
@hrharder I have addressed these little issues. I forgot to push before I went to lunch. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Freydal commentedAug 26, 2019
Overview
Description
Testing instructions
Types of changes
Notes
Status
[WIP]if necessary (changes not yet made).