Skip to content

/ kosu-monorepo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contracts: fix 'r' bonding curve parameter to match specification #241

Merged
merged 15 commits into from Aug 28, 2019
Merged

contracts: fix 'r' bonding curve parameter to match specification #241

merged 15 commits into from Aug 28, 2019

Conversation

@hrharder
Copy link
Member

hrharder commented Aug 28, 2019

Overview

Fixing parameterization of r (was 0.85, should be, and is now 0.29).

Adding tests to ensure this case.
hrharder added 2 commits Aug 28, 2019
@hrharder
fix curve parameterization
Verified
This commit was signed with a verified signature.
hrharder Henry Harder
GPG key ID: 3E4EB305434EC58E Learn about signing commits
e33ff86
@hrharder
separate scripts for delivering tokens
Verified
This commit was signed with a verified signature.
hrharder Henry Harder
GPG key ID: 3E4EB305434EC58E Learn about signing commits
Loading status checks…
55cc43a
@hrharder hrharder added the bug label Aug 28, 2019
@hrharder
Merge branch 'master' into fix/contracts/curve-parameterization
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f04c272
@hrharder hrharder changed the title Fix/contracts/curve parameterization contracts: fix 'r' bonding curve parameter to match specification Aug 28, 2019
Freydal and others added 12 commits Aug 28, 2019
@Freydal
Refactoring to have non parameterization tests use the global token
3abd659
@Freydal
Adding token config validation.
Loading status checks…
ec92e7d
@Freydal
running prettier.
Loading status checks…
4d7364c
@Freydal
Fixing a geth issue.
Loading status checks…
177bd82
@Freydal
Adding constructor back that now is causing a failure
299c9ea
@Freydal
Running prettier.
Loading status checks…
3cc0b80
@Freydal
Refactoring to work with ganache and geth
Loading status checks…
11c1575
@Freydal
Removing change I was tricked into changing.
6ef5fdb
@Freydal
Using the local token for the test.
4997140
@Freydal
Increase the magnitude so that tokens burned will be greater than the…
Loading status checks…
9a2e13a 
… full amount.
@Freydal
bonding more tokens.
Loading status checks…
b9b5afc
@hrharder
Merge branch 'master' into fix/contracts/curve-parameterization
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
91d4063
@hrharder hrharder requested a review from Freydal Aug 28, 2019
@Freydal
Freydal approved these changes Aug 28, 2019
View changes
@Freydal Freydal merged commit d1eb355 into master Aug 28, 2019
1 check passed
1 check passed
continuous-integration/drone/pr Build is passing
Details
@Freydal Freydal deleted the fix/contracts/curve-parameterization branch Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Freydal Freydal

Assignees

@hrharder hrharder

@Freydal Freydal

Labels
bug
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@hrharder @Freydal
You can’t perform that action at this time.