Skip to content

/ kosu-monorepo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-kosu: update scaling methods to be consistent #243

Merged
merged 7 commits into from Aug 29, 2019
Merged

go-kosu: update scaling methods to be consistent #243

merged 7 commits into from Aug 29, 2019

Conversation

@hrharder
Copy link
Member

hrharder commented Aug 29, 2019

Overview

Updates the scaleBalance method to do division directly with big.Int instead of using big.Rat and converting to int64 through a floating point number (potential source of non-determinism).
hrharder added 5 commits Aug 28, 2019
@hrharder
go-kosu: use pointer types in poster limit
Verified
This commit was signed with a verified signature.
hrharder Henry Harder
GPG key ID: 3E4EB305434EC58E Learn about signing commits
4fe6611
@hrharder
go-kosu: update scaleBalance to not use Rat
Verified
This commit was signed with a verified signature.
hrharder Henry Harder
GPG key ID: 3E4EB305434EC58E Learn about signing commits
cf6a4b2
@hrharder
go-kosu: fix copy of big.Ints
Verified
This commit was signed with a verified signature.
hrharder Henry Harder
GPG key ID: 3E4EB305434EC58E Learn about signing commits
dfaf411
@hrharder
go-kosu: re-add gosec lint skip
Verified
This commit was signed with a verified signature.
hrharder Henry Harder
GPG key ID: 3E4EB305434EC58E Learn about signing commits
8a916aa
@hrharder
go-kosu: update overflow check for consistency
Verified
This commit was signed with a verified signature.
hrharder Henry Harder
GPG key ID: 3E4EB305434EC58E Learn about signing commits
Loading status checks…
9c82c07
@hrharder hrharder requested a review from gchaincl Aug 29, 2019
@gchaincl
Merge branch 'master' into refactor/go-kosu/consistent-int-scaling
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
92364bc
@gchaincl
gchaincl approved these changes Aug 29, 2019
View changes
packages/go-kosu/abci/rebalance.go Show resolved Hide resolved
packages/go-kosu/abci/witness.go Show resolved Hide resolved
@gchaincl
gchaincl approved these changes Aug 29, 2019
View changes
@gchaincl
Merge branch 'master' into refactor/go-kosu/consistent-int-scaling
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c36d07a
@hrharder hrharder merged commit 9b0a46f into master Aug 29, 2019
1 check passed
1 check passed
continuous-integration/drone/pr Build is passing
Details
@hrharder hrharder deleted the refactor/go-kosu/consistent-int-scaling branch Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gchaincl gchaincl

Assignees
No one assigned
Labels
enhancement go-kosu
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@hrharder @gchaincl
You can’t perform that action at this time.