go-kosu: update scaling methods to be consistent #243
+13
−10
go-kosu: update overflow check for consistency
- Loading branch information
| @@ -112,8 +112,8 @@ func scaleBalance(balance *big.Int) int64 { | ||
| ether.Exp(big.NewInt(10), big.NewInt(18), big.NewInt(0)) | ||
| scaled.Div(balance, ether) | ||
|
|
||
| if scaled.IsInt64() { | ||
| return scaled.Int64() | ||
| if !scaled.IsInt64() { | ||
| return math.MaxInt64 | ||
|
This conversation was marked as resolved
by gchaincl
|
||
| } | ||
| return math.MaxInt64 | ||
| return scaled.Int64() | ||
| } | ||
ProTip!
Use n and p to navigate between commits in a pull request.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
what are the implications of this?