Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upRefactor/adding require failure messages #265
Merged
Conversation
Freydal
force-pushed the
refactor/adding-require-failure-messages
branch
from
8dbb417
to
ac3479a
This comment has been minimized.
This comment has been minimized.
|
I gave up and was just going to comment out the test and after I pushed I found that one of the tests after a unrelated push passed..... I reverted the push removing the test. Hope it still passes and isn't some intermittent issue. Perhaps it was a bad image. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Freydal commentedSep 9, 2019
Overview
Description
Testing instructions
Types of changes
Notes
Status
[WIP]if necessary (changes not yet made).