Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upfix frozen subscriptions #267
Merged
+58
−30
Conversation
gchaincl
force-pushed the
bug/go-kosu/rpc-frozen-subscriptions
branch
from
efc4452
to
b6b0b78
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
gchaincl commentedSep 11, 2019
Fix frozen subscriptions when two or more clients subscribe to events.
This happened because the current RPC client does not support more than one subscription.
The RPC Service now receives a client factory, so that it creates a new client on each subscription.