Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix frozen subscriptions #267

Merged
merged 3 commits into from Sep 11, 2019
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

go-kosu: re-order rpc closers

  • Loading branch information
gchaincl committed Sep 11, 2019
commit b6b0b789cd0bd9ef35d1854c37e0cd0f550a9edc
@@ -73,7 +73,6 @@ func (s *Service) subscribeTM(ctx context.Context, query string) (*rpc.Subscript
rpcSub := notifier.CreateSubscription()
go func() {
defer closer()
defer client.Stop() // nolint

for {
select {
@@ -361,8 +360,8 @@ func (s *Service) NewOrders(ctx context.Context) (*rpc.Subscription, error) {
rpcSub := notifier.CreateSubscription()
blocks := make(chan *tmtypes.Block, 1024)
go func() {
defer closer()
defer close(blocks)
defer closer()

for {
select {
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.