native.scp_send: don't try to recreate remote dir if don't have sftp #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks good, thanks. Needs a short test though. See existing scp_send test. |
Contributor
Author
|
Cool. I'll look into it. Cheers |
Contributor
|
We are needing this fix to allow parallel-ssh to scp files to a system with sftp disabled. @timsampsoncujo - how can I help get this in? I can add the necessary tests either in your branch or push up a new MR with your changes and the test - please advise. |
Contributor
Author
|
@cpeel we abandoned parallel-ssh so be my guest to close this PR, cherry-pick whatever commits here or whatever. |
Contributor
|
@timsampsoncujo - got it, thanks. Maintainers: then I suggest you close this PR and go with #188 instead as that one pulls in this commit plus tests. |
Member
|
Continued in #188 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #157 I think