Skip to content

Conversation

@cpeel
Copy link
Contributor

@cpeel cpeel commented Dec 3, 2019

This builds off of @timsampsoncujo's PR in #160 (which fixes issue #157) to add the requested test.

This bug is suddenly blocking us and I'm simply trying to facilitate getting the fix in.

@pkittenis
Copy link
Member

Thanks for the PR! Looks good, will merge as soon as the unrelated CI failures are resolved.

@codecov
Copy link

codecov bot commented Aug 31, 2020

Codecov Report

Merging #188 into master will increase coverage by 1.50%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
+ Coverage   87.62%   89.13%   +1.50%     
==========================================
  Files          23       23              
  Lines        1673     1675       +2     
==========================================
+ Hits         1466     1493      +27     
+ Misses        207      182      -25     
Impacted Files Coverage Δ
pssh/clients/native/single.py 85.80% <100.00%> (+1.90%) ⬆️
pssh/clients/native/tunnel.py 88.06% <0.00%> (-1.71%) ⬇️
pssh/output.py 100.00% <0.00%> (ø)
pssh/clients/base/parallel.py 97.47% <0.00%> (+0.50%) ⬆️
pssh/clients/ssh/single.py 63.58% <0.00%> (+2.71%) ⬆️
pssh/clients/miko/single.py 92.12% <0.00%> (+4.62%) ⬆️
pssh/clients/miko/parallel.py 98.90% <0.00%> (+6.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa3e90b...b1ab4c3. Read the comment docs.

@pkittenis pkittenis merged commit 9717fe3 into ParallelSSH:master Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants