Skip to content

Conversation

@midhlajvs
Copy link

Used to update the hypervisors using the server list and command list file.

Used to update the hypervisors using the server list and command list file.
@pkittenis
Copy link
Member

Hi, thank you for contributing.

A couple points:

  • The syntax and format of the two input files is not shown. Can some sample files be provided, or alternatively make the code take two lists for host and command list respectively and generate those from files.
  • Is it intentional that each command is run sequentially?

Code comments in line.

Added code notes
@midhlajvs
Copy link
Author

Hi,

I made the suggested changes on the code, hosts and commands are loaded from the file as a list. It is deliberate to run the commands sequentially.

@pkittenis
Copy link
Member

Thanks, comments look great.

Can you review the in code comment about the print statement.

Getting syntax error on python 2 with the current code.

@pkittenis
Copy link
Member

Moved to wiki

@pkittenis pkittenis closed this Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants