fix: Accept uv duration words#577
Merged
Merged
Conversation
🚀 Dev Builds AvailableDevelopment builds for this PR are available in the workflow artifacts. Available builds:
Download the |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the UV exclude-newer duration parser to accept word-based units (e.g. 7 days) in addition to short suffixes (e.g. 7d), aligning the supply-chain check with UV’s config formats.
Changes:
- Extend
durationSecondsto recognizesecond(s),minute(s),hour(s),day(s),week(s)and tolerate whitespace between the number and unit. - Update UV-related test fixtures to use
exclude-newer = "7 days"instead ofexclude-newer = "7d".
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
checks/shared/package_manager_supply_chain.go |
Expands duration parsing logic to accept word-based units and whitespace. |
checks/shared/package_manager_supply_chain_test.go |
Adjusts UV config test inputs to cover the word-based duration format. |
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
zupo
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: