Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧 Inject the default schemas properties when loading it #1357

Merged
merged 1 commit into from Apr 4, 2016

Conversation

flovilmart
Copy link
Contributor

  • injects default schema upon schema load

this maximizes the compatibility with previously set CLP before migration where the Schema wouldn't have all the default keys set

- injects default schema upon schema load
@flovilmart flovilmart changed the title 🎉 fixes #1355 Inject the default schemas properties when loading it Apr 4, 2016
@codecov-io
Copy link

Current coverage is 93.08%

Merging #1357 into master will increase coverage by +0.01% as of b885974

@@            master   #1357   diff @@
======================================
  Files           84      84       
  Stmts         5345    5393    +48
  Branches       981    1003    +22
  Methods          0       0       
======================================
+ Hit           4975    5020    +45
  Partial          9       9       
- Missed         361     364     +3

Review entire Coverage Diff as of b885974

Powered by Codecov. Updated on successful CI builds.

@flovilmart flovilmart changed the title Inject the default schemas properties when loading it 🚧 Inject the default schemas properties when loading it Apr 4, 2016
@drew-gross drew-gross merged commit 89df778 into master Apr 4, 2016
@drew-gross drew-gross deleted the schema-defaults branch April 4, 2016 15:56
@flovilmart
Copy link
Contributor Author

There may still be an edge case that is not covered.

@drew-gross
Copy link
Contributor

Which one would that be?

@flovilmart
Copy link
Contributor Author

Querying the GET /schemas/ on system classes is empty, it should return the default schema no?

@drew-gross
Copy link
Contributor

There are tests for that which are passing so I guess it's working. Schemas API has it's own way of merging the defaults schemas.

@flovilmart
Copy link
Contributor Author

fine for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants