Style improvements #2475
Merged
Style improvements #2475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
flovilmart
commented
Aug 6, 2016
flovilmart
commented
- Enable HooksRouter by default (as part of the node SDK)
- Moves problematic middlewares on per route basis
- Modernizes DatabaseController and middleware imports
- Moves test api mount to helper
Current coverage is 92.47% (diff: 97.80%)@@ master #2475 diff @@
==========================================
Files 95 93 -2
Lines 10706 10602 -104
Methods 1312 1309 -3
Messages 0 0
Branches 1738 1721 -17
==========================================
- Hits 9837 9804 -33
+ Misses 869 798 -71
Partials 0 0
|
|
@flovilmart updated the pull request. |
|
@flovilmart updated the pull request. |
| return { response: {} }; | ||
| }); | ||
| return Promise.resolve().then(() => { | ||
| this.adapter.appOpened(req.body, req); |
|
@flovilmart updated the pull request. |
| @@ -17,4 +16,4 @@ _ParseServer.createLiveQueryServer = ParseServer.createLiveQueryServer; | |||
| let GCSAdapter = useExternal('GCSAdapter', 'parse-server-gcs-adapter'); | |||
|
|
|||
| export default ParseServer; | |||
| export { S3Adapter, GCSAdapter, FileSystemAdapter, InMemoryCacheAdapter, TestUtils, logger, _ParseServer as ParseServer }; | |||
| export { S3Adapter, GCSAdapter, FileSystemAdapter, InMemoryCacheAdapter, logger, _ParseServer as ParseServer }; | |||
There was a problem hiding this comment.
|
Looks awesome, just need to either keep TestUtils exported, or change the JS SDK. Feel free to merge after that. |
|
I believe it's good now, let me know if the TestUtils change is good :) |
|
@flovilmart updated the pull request. |
This was referenced Aug 8, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.