Adds liniting into the workflow #3082

Merged
merged 9 commits into from Nov 24, 2016

Projects

None yet

3 participants

@flovilmart
Collaborator
flovilmart commented Nov 20, 2016 edited

Adds linting to to workflow, reporting build errors when lint is no OK.
Rules are the recommended rules.
This should work out of the box in your favorite editor.

@facebook-github-bot

@flovilmart updated the pull request - view changes

@facebook-github-bot

@flovilmart updated the pull request - view changes

@facebook-github-bot

@flovilmart updated the pull request - view changes

@facebook-github-bot

@flovilmart updated the pull request - view changes

@steven-supersolid

LGTM and like that we are keeping the rules close to the recommended

+ "ecmaVersion": 6,
+ "sourceType": "module"
+ },
+ "rules": {
@steven-supersolid
steven-supersolid Nov 24, 2016 Contributor

nits:

  • no-extra-boolean-cast doesn't seem to be required
  • Would be clearer to use string value "off" for no-console
  • no-empty would be closer to eslint:recommended with value ["error", { "allowEmptyCatch": true }], otherwise would use "off"
@flovilmart
flovilmart Nov 24, 2016 Collaborator

I'll add the nits and rebase :)

@facebook-github-bot

@flovilmart updated the pull request - view changes

@flovilmart flovilmart nits
fa11ed6
@facebook-github-bot

@flovilmart updated the pull request - view changes

@flovilmart flovilmart no no-empty rule
79463ce
@facebook-github-bot

@flovilmart updated the pull request - view changes

@flovilmart flovilmart merged commit 8c2c76d into master Nov 24, 2016

3 checks passed

codecov/patch 94.39% of diff hit (target 0.00%)
Details
codecov/project 91.93% (target 90.00%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@flovilmart flovilmart deleted the es-lint branch Nov 24, 2016
@rsouzas rsouzas added a commit to back4app/parse-server that referenced this pull request Dec 3, 2016
@flovilmart @rsouzas flovilmart + rsouzas Adds liniting into the workflow (#3082)
* initial linting of src

* fix indent to 2 spaces

* Removes unnecessary rules

* ignore spec folder for now

* Spec linting

* Fix spec indent

* nits

* nits

* no no-empty rule
bad820e
@Jcarlosjunior Jcarlosjunior added a commit to back4app/parse-server that referenced this pull request Dec 13, 2016
@flovilmart @Jcarlosjunior flovilmart + Jcarlosjunior Adds liniting into the workflow (#3082)
* initial linting of src

* fix indent to 2 spaces

* Removes unnecessary rules

* ignore spec folder for now

* Spec linting

* Fix spec indent

* nits

* nits

* no no-empty rule
54b5e35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment