lint before test. #3147

Merged
merged 1 commit into from Nov 30, 2016

Projects

None yet

3 participants

@acinader
Collaborator

Also turn on lint cacheing to make this change painless ;)
add lint cache to gitignore...

whadda ya think?

@acinader acinader lint before test.
Also turn on lint cacheing to make this change painless ;)
add lint cache to gitignore...
ee27ee0
@flovilmart
Collaborator

That seems to be very cool!! I'll check It out tonight. Was afraid the time of test would increase :)

@flovilmart
Collaborator

first lint:

real	0m9.124s
user	0m9.431s
sys	0m0.479s

subsequent lint (no changes):

real	0m1.623s
user	0m1.509s
sys	0m0.200s

subsequent lint (small change):

real	0m2.779s
user	0m2.137s
sys	0m0.333s
@flovilmart flovilmart merged commit 4d17bed into ParsePlatform:master Nov 30, 2016

3 checks passed

codecov/patch 100% of diff hit (target 0.00%)
Details
codecov/project 91.98% (target 90.00%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@acinader
Collaborator

we might need to start a collection to get you a new machine @flovilmart ;)

➜  parse-server git:(master) time npm run lint

> parse-server@2.2.25 lint /Users/arthur/code/parse-server
> eslint --cache ./

npm run lint  7.55s user 0.40s system 112% cpu 7.083 total
➜  parse-server git:(master) time npm run lint

> parse-server@2.2.25 lint /Users/arthur/code/parse-server
> eslint --cache ./

npm run lint  1.31s user 0.17s system 103% cpu 1.431 total
➜  parse-server git:(master) ✗ time npm run lint

> parse-server@2.2.25 lint /Users/arthur/code/parse-server
> eslint --cache ./

npm run lint  1.65s user 0.19s system 105% cpu 1.745 total
➜  parse-server git:(master) ✗ 
@flovilmart
Collaborator

A new MBP 13 with 16gb / 3.1Ghz / 512Gb just arrived :) making the backups on the 2014 ATM :)

@acinader
Collaborator
@flovilmart
Collaborator

Probably the most useless 200mhz ever

@rsouzas rsouzas added a commit to back4app/parse-server that referenced this pull request Dec 3, 2016
@acinader @rsouzas acinader + rsouzas lint before test. (#3147)
Also turn on lint cacheing to make this change painless ;)
add lint cache to gitignore...
a4c10e3
@Jcarlosjunior Jcarlosjunior added a commit to back4app/parse-server that referenced this pull request Dec 13, 2016
@acinader @Jcarlosjunior acinader + Jcarlosjunior lint before test. (#3147)
Also turn on lint cacheing to make this change painless ;)
add lint cache to gitignore...
87b9d7a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment