Skip to content
This repository has been archived by the owner on Mar 24, 2021. It is now read-only.

roundrobin partition assignment #748

Merged
merged 16 commits into from Dec 4, 2017
Merged

roundrobin partition assignment #748

merged 16 commits into from Dec 4, 2017

Conversation

emmettbutler
Copy link
Contributor

This pull request adds support for the roundrobin partition assignment strategy for #657

@codecov-io
Copy link

codecov-io commented Dec 4, 2017

Codecov Report

Merging #748 into master will increase coverage by 0.17%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #748      +/-   ##
==========================================
+ Coverage   84.48%   84.65%   +0.17%     
==========================================
  Files          26       27       +1     
  Lines        3197     3220      +23     
  Branches      499      502       +3     
==========================================
+ Hits         2701     2726      +25     
- Misses        362      364       +2     
+ Partials      134      130       -4
Impacted Files Coverage Δ
pykafka/managedbalancedconsumer.py 77.02% <100%> (-7.12%) ⬇️
pykafka/balancedconsumer.py 94.25% <100%> (+2.9%) ⬆️
pykafka/broker.py 91.55% <100%> (+1.94%) ⬆️
pykafka/membershipprotocol.py 100% <100%> (ø)
pykafka/protocol.py 95.74% <100%> (-0.29%) ⬇️
pykafka/cluster.py 72.17% <0%> (ø) ⬆️
pykafka/handlers.py 97.01% <0%> (ø) ⬆️
pykafka/connection.py 88.29% <0%> (ø) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42b09e6...5bbc785. Read the comment docs.

@emmettbutler emmettbutler changed the title [WIP] round robin partition assignment round robin partition assignment Dec 4, 2017
@emmettbutler emmettbutler changed the title round robin partition assignment roundrobin partition assignment Dec 4, 2017
@emmettbutler emmettbutler merged commit fb5bb06 into master Dec 4, 2017
@emmettbutler emmettbutler deleted the feature/rr_assignment branch December 4, 2017 23:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants