Harden front-end tracker E2E assertions against attribute-order changes#4244
Merged
Merged
Conversation
Copilot created this pull request from a session on behalf of
acicovic
May 25, 2026 11:48
View session
…nText Agent-Logs-Url: https://github.com/Parsely/wp-parsely/sessions/611f3a4a-2a97-4629-b706-5266a34ba204 Co-authored-by: acicovic <23142906+acicovic@users.noreply.github.com>
Collaborator
|
@coderabbitai review Make sure that the tests have been modified in a way that still keeps them thorough and doesn't introduce any lacks compared to their previous state. |
Contributor
|
Tip For best results, initiate chat on the files or code changes.
Test 1 — "Should work as expected when only Site ID is provided"
Test 2 — "Should work as expected when a Site ID and API Secret are provided"All shared checks mirror Test 1 (same analysis above). The key change:
Conclusion: No coverage gaps were introduced. The refactoring is sound — every original assertion has a direct, semantically equivalent replacement, and the attribute decomposition approach is actually an improvement over the brittle single-string HTML matches. |
acicovic
approved these changes
May 25, 2026
github-actions Bot
added a commit
that referenced
this pull request
May 25, 2026
…to-end-test-failures Harden front-end tracker E2E assertions against attribute-order changes" (fba31f4)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
front-end-tracker.spec.ts:98—toContainTextreturns""for<script>elements (Playwright limitation for non-visible elements)toContainTextwithevaluate()→el.textContent+ plainexpect().toContain()on line 98