New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race condition in DFK #102

Closed
yadudoc opened this Issue Feb 26, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@yadudoc
Contributor

yadudoc commented Feb 26, 2018

@joezuntz reported tasks launched via the ThreadPoolExecutor getting executed multiple times.
The suspicion is that the DFK code for handling updating task updates does not lock prior to launching tasks and multiple threads could be facing a race-condition.

The fix should be a lock on the check and launch of tasks to the executor. This is serious enough to warrant a point release once the fixes are tested.

@yadudoc yadudoc added the bug label Feb 26, 2018

@yadudoc yadudoc added this to the Parsl-0.5.0 milestone Feb 26, 2018

@yadudoc yadudoc self-assigned this Feb 26, 2018

yadudoc added a commit that referenced this issue Feb 26, 2018

Potential fix for #102
Added a critical section to dfk.handle_update() that acquires a lock
and does a check on whether a task is pending before launching to the
executor.
@yadudoc

This comment has been minimized.

Contributor

yadudoc commented Feb 27, 2018

Merged to master. Fix confirmed by @joezuntz. Closing.

@yadudoc yadudoc closed this Feb 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment