Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak test organization #128

Closed
annawoodard opened this Issue Mar 11, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@annawoodard
Copy link
Collaborator

annawoodard commented Mar 11, 2018

This is related to #121. When the Jenkins server is setup, we will regularly run all of the tests before PRs are merged. That will require that any contributor can exactly reproduce whatever tests are going to be run, to be sure that their feature branch passes and address any issues beforehand. Therefore, we should tweak the tests to remove hardcoded usernames.

@annawoodard

This comment has been minimized.

Copy link
Collaborator Author

annawoodard commented Mar 16, 2018

I'm adjusting the title to add a few related items here.

We should organize the tests according to how often the are run: 1) at least before every PR (and afterwards automatically via jenkins) and 2) before every release (this should include larger scale, stress-testing). We should be able to run all tests in either category easily. @yadudoc had a great idea of for example having a bash script we could run to set env variables (for example, usernames on various resources). Alternatively, we could have a test config where devs could store that info.

@annawoodard annawoodard changed the title Do not hardcode usernames in tests Tweak test organization Mar 16, 2018

@yadudoc yadudoc added the enhancement label Apr 23, 2018

@yadudoc yadudoc added this to the Parsl-0.6.0 milestone Apr 23, 2018

@annawoodard annawoodard referenced this issue May 11, 2018

Merged

Tests #128 #272

@yadudoc yadudoc closed this in #272 May 16, 2018

yadudoc added a commit that referenced this issue May 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.