New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Results added to appCache before retries exhausted #130

Closed
yadudoc opened this Issue Mar 13, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@yadudoc
Contributor

yadudoc commented Mar 13, 2018

If an app fails, the exceptions are entered into the appCache before the logic that handles retries. This results in retry attempts being skipped and the first failure being returned, effectively blocking retries.

The task goes through the following state transitions :

     pending --> running --> completed
      ^            |
      |            V
      +--------? failed       

We should only memoize when the task has reached the terminal states (completed/failed).

@yadudoc yadudoc added the enhancement label Mar 13, 2018

@yadudoc yadudoc added this to the Parsl-0.5.0 milestone Mar 13, 2018

@yadudoc yadudoc self-assigned this Mar 13, 2018

@yadudoc

This comment has been minimized.

Contributor

yadudoc commented Mar 22, 2018

This is fixed in branch Auto_checkpoint_#106

@yadudoc yadudoc closed this Mar 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment