New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Globus path mapping in config #165

Closed
kylechard opened this Issue Mar 26, 2018 · 4 comments

Comments

Projects
None yet
4 participants
@kylechard
Collaborator

kylechard commented Mar 26, 2018

At the moment we are conflating the Globus/Local path mapping and the working directory. I think we should break this config up as follows:

 "data": {
     "globus": {
           "endpoint_name": "7d2dc622-2edb-11e8-b8be-0ac6873fc732",
           "endpoint_path": "/home/globus/kyle",
            "local_path" : "/home/user/kyle"
       }
       "working_dir" : "/home/user/kyle/parsl-stuff
 }

This would then allow us to keep the mapping in the site-specific Globus object (from endpoint_path to local_path) and manage the working directory as a general data option. I expect this will be easier in the long run as we transition to externally cataloged site definitions too.

@lukaszlacinski

This comment has been minimized.

Collaborator

lukaszlacinski commented Mar 28, 2018

If we require that (if endpoint_path is present in a config) the endpoint_path must be defined that way, so <endpoint_name><endpoint_path> points to file:///<working_dir>, we do not need local_path because it will be redundant with working_dir.

lukaszlacinski added a commit that referenced this issue Mar 28, 2018

@lukaszlacinski

This comment has been minimized.

Collaborator

lukaszlacinski commented Mar 28, 2018

"working_dir" specifies where files will be staged in to. "endpoint_path" is optional and by default is the same as "working_dir". "endpoint_path" is needed only when <endpoint_name><working_dir> does not correspond with working_dir on the filesystem. In this case, endpoint_path needs to be specified, so <endpoint_name><endpoint_path> points to the working_dir on the filesystem.

"data": {
"globus": {
"endpoint_name": "7d2dc622-2edb-11e8-b8be-0ac6873fc732",
"endpoint_path": "/kyle/parsl-stuff"
}
"working_dir" : "/home/user/kyle/parsl-stuff
}

@kylechard

This comment has been minimized.

Collaborator

kylechard commented Mar 28, 2018

In the long run I expect the person defining the Globus config will be different than the person defining the working_dir. So it would be preferable to include both endpoint_path and local_path to specify the mapping independent of the working directory.

@annawoodard

This comment has been minimized.

Collaborator

annawoodard commented Mar 28, 2018

To clarify @kylechard's comment, I think what he's saying is to have what we had before with the working_dir as an additional option

annawoodard added a commit that referenced this issue Mar 29, 2018

@yadudoc yadudoc added the enhancement label May 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment