Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow `DataFuture` to be initialized with a `str` file object #185

Closed
annawoodard opened this Issue Apr 2, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@annawoodard
Copy link
Collaborator

annawoodard commented Apr 2, 2018

Here we check if file_obj is str. Now that File is subclassed from str, this will always evaluate as True.

annawoodard added a commit that referenced this issue Apr 2, 2018

Allow strings in `DataFuture` initialization
Now that `File` is subclassed from `str`, `isinstance(File, str)`
will always evaluate as True. Fixes #185.

annawoodard referenced this issue Apr 3, 2018

Merge pull request #186 from Parsl/allow-strings-#185
Allow strings in `DataFuture` initialization

@annawoodard annawoodard self-assigned this May 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.