New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing Files breaks over IPP #200

Closed
yadudoc opened this Issue Apr 9, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@yadudoc
Contributor

yadudoc commented Apr 9, 2018

The new File class contains a dictionary that maps DataFutures for each site to which it is being staged and contains a reference to the DataManager. Neither of these are pickle-able.

So if we do something like this 馃憤

data = File("foo.txt")
fu = remote_app(inputs=[data])
fu.result() # <--- We'll get an error from here

Here's the relevant piece from the exception traceback :

File "/usr/local/lib/python3.5/dist-packages/ipyparallel/serialize/serialize.py", line 112, in serialize_object
   buffers.insert(0, pickle.dumps(cobj, PICKLE_PROTOCOL))
TypeError: can't pickle _thread.lock objects

I believe that the File object is the best place to hold the Future information about itself, and that would give us the opportunity to do smarter file staging in the future. So I propose that we fix this with a custom pickler for the File class.

This is blocker for 0.5.0.

@yadudoc yadudoc added the bug label Apr 9, 2018

@yadudoc yadudoc added this to the Parsl-0.5.0 milestone Apr 9, 2018

yadudoc added a commit that referenced this issue Apr 10, 2018

yadudoc added a commit that referenced this issue Apr 10, 2018

yadudoc added a commit that referenced this issue Apr 12, 2018

@yadudoc yadudoc closed this in #201 Apr 12, 2018

yadudoc added a commit that referenced this issue Apr 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment