New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`task_exit` checkpointing repeatedly truncates checkpoint file during run #230

Closed
benclifford opened this Issue Apr 25, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@benclifford
Contributor

benclifford commented Apr 25, 2018

With config['globals']['checkpointMode'] = 'task_exit', the checkpoint file remains small, and sometimes shrinks, sometimes even to 0.

It looks like the file opening mode is wrong. I have a one line fix.

benc@dogger:~/parsl/desc-skeleton/runinfo/107/checkpoint$ ls tasks.pkl -l
-rw-r--r-- 1 benc benc 90 Apr 25 10:13 tasks.pkl
benc@dogger:~/parsl/desc-skeleton/runinfo/107/checkpoint$ ls tasks.pkl -l
-rw-r--r-- 1 benc benc 90 Apr 25 10:13 tasks.pkl
benc@dogger:~/parsl/desc-skeleton/runinfo/107/checkpoint$ ls tasks.pkl -l
-rw-r--r-- 1 benc benc 90 Apr 25 10:13 tasks.pkl
benc@dogger:~/parsl/desc-skeleton/runinfo/107/checkpoint$ ls tasks.pkl -l
-rw-r--r-- 1 benc benc 90 Apr 25 10:13 tasks.pkl
benc@dogger:~/parsl/desc-skeleton/runinfo/107/checkpoint$ ls tasks.pkl -l
-rw-r--r-- 1 benc benc 90 Apr 25 10:13 tasks.pkl
benc@dogger:~/parsl/desc-skeleton/runinfo/107/checkpoint$ ls tasks.pkl -l
-rw-r--r-- 1 benc benc 90 Apr 25 10:13 tasks.pkl
benc@dogger:~/parsl/desc-skeleton/runinfo/107/checkpoint$ ls tasks.pkl -l
-rw-r--r-- 1 benc benc 0 Apr 25 10:13 tasks.pkl
benc@dogger:~/parsl/desc-skeleton/runinfo/107/checkpoint$ ls tasks.pkl -l
-rw-r--r-- 1 benc benc 0 Apr 25 10:13 tasks.pkl
benc@dogger:~/parsl/desc-skeleton/runinfo/107/checkpoint$ ls tasks.pkl -l
-rw-r--r-- 1 benc benc 0 Apr 25 10:13 tasks.pkl
benc@dogger:~/parsl/desc-skeleton/runinfo/107/checkpoint$ ls tasks.pkl -l
-rw-r--r-- 1 benc benc 0 Apr 25 10:13 tasks.pkl
benc@dogger:~/parsl/desc-skeleton/runinfo/107/checkpoint$ ls tasks.pkl -l
-rw-r--r-- 1 benc benc 0 Apr 25 10:13 tasks.pkl
benc@dogger:~/parsl/desc-skeleton/runinfo/107/checkpoint$ ls tasks.pkl -l
-rw-r--r-- 1 benc benc 0 Apr 25 10:13 tasks.pkl
benc@dogger:~/parsl/desc-skeleton/runinfo/107/checkpoint$ ls tasks.pkl -l
-rw-r--r-- 1 benc benc 0 Apr 25 10:13 tasks.pkl
benc@dogger:~/parsl/desc-skeleton/runinfo/107/checkpoint$ ls tasks.pkl -l
-rw-r--r-- 1 benc benc 0 Apr 25 10:13 tasks.pkl

@benclifford benclifford self-assigned this Apr 25, 2018

benclifford added a commit that referenced this issue Apr 25, 2018

Change checkpoint file modes to append. Fixes issue #230.
Previous behaviour truncated and overwrote the checkpoint
file at each checkpoint, although it was intended to
append.

The previous mode, wb+, means to open the file for both reading and
writing, truncating if necessary - some documentation refers to
this as "updating", which may be the source of confusion.

The new mode, ab, means to open the file for writing, but without
truncating, and positioned initially at the end of the file.

@yadudoc yadudoc added the bug label Apr 25, 2018

@yadudoc yadudoc added this to the Parsl-0.6.0 milestone Apr 25, 2018

yadudoc added a commit that referenced this issue Apr 25, 2018

Merge pull request #231 from Parsl/benc-fix-230
Change checkpoint file modes to append. Fixes issue #230.

@yadudoc yadudoc changed the title from `task_exit` checkpointing erases repeatedly truncates checkpoint file during run to `task_exit` checkpointing repeatedly truncates checkpoint file during run Apr 27, 2018

@yadudoc

This comment has been minimized.

Contributor

yadudoc commented Apr 27, 2018

#231 Fixes this issue

@yadudoc yadudoc closed this Apr 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment