New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe code state more precisely in the logging #242

Closed
annawoodard opened this Issue Apr 26, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@annawoodard
Collaborator

annawoodard commented Apr 26, 2018

We currently log the Parsl version. For debugging, it would be convenient to log the most recent commit hash and whether or not there are any additional changes.

annawoodard added a commit that referenced this issue Apr 26, 2018

Describe code state more precisely in the logging
Users that have installed pip with `pip install parsl` will continue to
just see the Parsl version. Developers will additionally see the hash of
the last commit and `dirty` or `clean`, depending on if there are
uncommitted changes. Fixes #242.

annawoodard added a commit that referenced this issue Apr 26, 2018

Describe code state more precisely in the logging
Users that have installed pip with `pip install parsl` will continue to
just see the Parsl version. Developers will additionally see the hash of
the last commit and `dirty` or `clean`, depending on if there are
uncommitted changes. Fixes #242.
@yadudoc

This comment has been minimized.

Contributor

yadudoc commented Apr 26, 2018

We badly need this!

@yadudoc yadudoc added the enhancement label Apr 27, 2018

@yadudoc yadudoc added this to the Parsl-0.6.0 milestone Apr 27, 2018

@benclifford

This comment has been minimized.

Contributor

benclifford commented Apr 27, 2018

I found this information really useful when debugging other people's stuff.

Swift had some scripting that did pretty much exactly this, which was run as part of the build process.

This is the current version:
https://github.com/swift-lang/swift-k/blob/master/libexec/svn-revision

@yadudoc yadudoc closed this in #243 Apr 30, 2018

yadudoc added a commit that referenced this issue Apr 30, 2018

Merge pull request #243 from Parsl/better-version-logging-#242
Describe code state more precisely in the logging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment