Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make launchers classes to be consistent #360

Closed
yadudoc opened this Issue Jun 27, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@yadudoc
Copy link
Member

yadudoc commented Jun 27, 2018

Currently we specify launchers by name to the provider, whereas it would be more elegant and consistent to have the launchers be classes. Launchers could then be specified in the config by passing a launcher object. We should have this added for 0.6.0 since we are making broad changes to both parsl and libsubmit.

The launcher classes should have a __call__ function which can be invoked by the provider. This would allow for an additional check to be made to confirm that the object passed to the config is in fact callable.

@yadudoc yadudoc self-assigned this Jun 27, 2018

@yadudoc yadudoc added the enhancement label Jun 27, 2018

@yadudoc yadudoc added this to the Parsl-0.6.0 milestone Jun 27, 2018

@yadudoc

This comment has been minimized.

Copy link
Member Author

yadudoc commented Jul 3, 2018

This is done in Libsubmit v0.5.0a0

@yadudoc yadudoc closed this Jul 3, 2018

benclifford pushed a commit that referenced this issue Aug 9, 2018

Several major changes. Fixes #360.
* Added new launcher base class requiring concrete classes to implement __call__
* Added a SimpleLauncher that returns the command string without wrapping
* All existing launchers have been updated to the new interface

annawoodard pushed a commit that referenced this issue Sep 24, 2018

Several major changes. Fixes #360.
* Added new launcher base class requiring concrete classes to implement __call__
* Added a SimpleLauncher that returns the command string without wrapping
* All existing launchers have been updated to the new interface
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.