New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config defaults not being set if any option is specified. #74

Closed
yadudoc opened this Issue Jan 20, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@yadudoc
Contributor

yadudoc commented Jan 20, 2018

If any of the top level config options are specified by the other, for eg :
'globals': {'lazyErrors': True }
Other options are not set to defaults such as
'globals': {'strategy': 'simple', 'usageTracking': True}

@yadudoc yadudoc self-assigned this Jan 20, 2018

@yadudoc yadudoc added the bug label Jan 20, 2018

@yadudoc yadudoc added this to the Parsl-0.4.0 milestone Jan 20, 2018

yadudoc added a commit that referenced this issue Jan 20, 2018

Fixing issue with partial config updates #74.
Config updates in the top level was being updated with dict.update()
which did not recursively update top level options such as
globals, controller etc when any option is provided by the user.
Fixed with recursive_update.
@yadudoc

This comment has been minimized.

Contributor

yadudoc commented Jan 20, 2018

Fixed in above references commit.

@yadudoc yadudoc closed this Jan 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment