Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaner logging #85

Closed
yadudoc opened this Issue Feb 2, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@yadudoc
Copy link
Member

yadudoc commented Feb 2, 2018

Logs for the user to understand what apps ran, how, where, and what happened.
Logs for the dev for complete sequence of events.

@yadudoc yadudoc added this to the Parsl-0.5.0 milestone Feb 2, 2018

@yadudoc yadudoc self-assigned this Feb 2, 2018

yadudoc added a commit that referenced this issue Mar 7, 2018

@annawoodard

This comment has been minimized.

Copy link
Collaborator

annawoodard commented Mar 7, 2018

Moving the discussion here from #63. Thanks for showing an example log! I think things look great! I vote for a few minor tweaks:

  1. Avoid messages with no verb (use sentences where possible)
  2. Task 14 instead of Task[14] because it could be confusing to users (same syntax as accessing index 14 in list called Task)
  3. Milliseconds might be more time granularity than needed
  4. Prefer i.e. failed over FAILED unless specifically referring to the state

So instead of:

2018-03-05 14:46:48,120 parsl.dataflow.dflow [INFO] Task[20] App:sleep_fail Depends:[10, 11, 12, 13, 14, 15, 16, 17, 18, 19]
2018-03-05 14:46:48,326 parsl.dataflow.dflow [INFO] Task[10] Launching Task
2018-03-05 14:46:48,568 parsl.dataflow.dflow [INFO] Task[6]: FAILED with <Future at 0x7f84375fdfd0 state=finished raised Exception>
2018-03-05 14:46:49,034 parsl.dataflow.dflow [INFO] Task[14]: All retry attempts:2 have failed

consider:

2018-03-05 14:46:48 parsl.dataflow.dflow [INFO] Submitting Task 20 for App sleep_fail with dependencies on Tasks 10, 11, 12, 13, 14, 15, 16, 17, 18, 19
2018-03-05 14:46:48 parsl.dataflow.dflow [INFO] Launching Task 10
2018-03-05 14:46:48 parsl.dataflow.dflow [INFO] Task 6 failed with <Future at 0x7f84375fdfd0 state=FINISHED raised Exception>
2018-03-05 14:46:49 parsl.dataflow.dflow [INFO] Task 14 has failed each of the 2 allowed retry attempts

My goal with log lines is to have something that looks like <TASK_ID> . This is easier on the eyes, and makes it easy to grep by task.

I don't find grepping for Task 14 any more difficult than Task[14], and I think the former is less confusing for users because it can only have a single meaning.

@annawoodard

This comment has been minimized.

Copy link
Collaborator

annawoodard commented Mar 7, 2018

@yadudoc prefers the task name at the beginning, here's an option:

2018-03-05 14:46:48 parsl.dataflow.dflow [INFO] Task 20 is being submitted for App sleep_fail with dependencies on Tasks 10, 11, 12, 13, 14, 15, 16, 17, 18, 19
2018-03-05 14:46:48 parsl.dataflow.dflow [INFO] Task 10 is being launched
2018-03-05 14:46:48 parsl.dataflow.dflow [INFO] Task 6 failed with <Future at 0x7f84375fdfd0 state=FINISHED raised Exception>
2018-03-05 14:46:49 parsl.dataflow.dflow [INFO] Task 14 has failed each of the 2 allowed retry attempts

yadudoc added a commit that referenced this issue Mar 8, 2018

Changes to log lines based on #85. More changes pending.
* readable log lines.
* log lines from tasks follow the structure <TaskId> <description> <additional_info>

@yadudoc yadudoc referenced this issue Mar 8, 2018

Merged

Retries #63 #114

yadudoc added a commit that referenced this issue Mar 9, 2018

yadudoc added a commit that referenced this issue Mar 9, 2018

Changes to log lines based on #85. More changes pending.
* readable log lines.
* log lines from tasks follow the structure <TaskId> <description> <additional_info>
@yadudoc

This comment has been minimized.

Copy link
Member Author

yadudoc commented Mar 21, 2018

@annawoodard Let's close this one ? It's hard to close open ended issues like this, but for now I think we've addressed most of our known concerns.

@annawoodard

This comment has been minimized.

Copy link
Collaborator

annawoodard commented Mar 21, 2018

Sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.