Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsl caching throws errors even when caching is disabled #90

Closed
yadudoc opened this Issue Feb 5, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@yadudoc
Copy link
Member

yadudoc commented Feb 5, 2018

There are two parts to this issue:

  1. Parsl attempts to make a function hash even when hashing is disabled
  2. Fn hashing doesn't work well with dill.source.getsources or getsourcelines on jupyter notebooks.

Conditionals to be added to the app_factory, and on detecting IOError switch to the getsourcelines from the inspect module.

yadudoc added a commit that referenced this issue Feb 5, 2018

Fixed issue with fn hashing Ref: #90.
* Inspect module's getsource works more reliably on both jupyter notebooks
  and standard python interpretor.
* Fn source extraction and hashing only happens if cache=True
* Removed dill dependency from requirements
@yadudoc

This comment has been minimized.

Copy link
Member Author

yadudoc commented Feb 5, 2018

Potential fix is out.

@yadudoc yadudoc self-assigned this Feb 5, 2018

@yadudoc yadudoc added the bug label Feb 5, 2018

@yadudoc yadudoc closed this Feb 5, 2018

@yadudoc yadudoc added this to the Parsl-0.4.0 milestone Feb 5, 2018

yadudoc added a commit that referenced this issue Feb 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.