Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a local config that can be loaded #96

Closed
kylechard opened this Issue Feb 10, 2018 · 4 comments

Comments

Projects
None yet
4 participants
@kylechard
Copy link
Collaborator

kylechard commented Feb 10, 2018

I think its confusing to have two different ways to instantiate the DFK. I think we should do away with the shorthand way and instead push people towards using config objects. The easiest way would be to include a local config in the Parsl package that could be imported.

E.g., from parsl.config import local_config

@yadudoc yadudoc added the enhancement label Feb 14, 2018

@yadudoc yadudoc added this to the Parsl-0.5.0 milestone Feb 14, 2018

@yadudoc

This comment has been minimized.

Copy link
Member

yadudoc commented Feb 22, 2018

In the latest parsl, we now have a configs module that can be expanded to support a curated set of sites.

from parsl.configs.local import localThreads
from parsl.configs.local import localIPP

The above works in the parsl master branch.

The drawback here is that we are provider whole configs that contain a single site, rather than a method
that pulls together multiple sites into a one config. This is what I think makes most sense:

from parsl.configs import configBase
from parsl.sites import localThreads, coriRemote, thetaRemote
configBase['sites'] = [localThreads, coriRemote, thetaRemote]

I think this would make the config more composable, but I'm not entirely sure how many users would want/use multi-site configs.

@mjwilde

This comment has been minimized.

Copy link
Contributor

mjwilde commented Feb 23, 2018

@yadudoc

This comment has been minimized.

Copy link
Member

yadudoc commented Mar 2, 2018

@kylechard If you think the local configs are okay can we close this one ? I think standardizing site configs, and allowing users to combine sites is going to take more design that we should defer until we have more user input.

@mjwilde We are treating configs as code/datastructures that can be imported, modified etc. I suspect that I might be misunderstanding your comment.

@yadudoc yadudoc closed this Mar 5, 2018

yadudoc added a commit that referenced this issue Mar 6, 2018

Adding parsl.configs default configs.
Cherrypicking functionality from the retries branch to smooth out some tests.
This is functionality that addresses #96.
@benclifford

This comment has been minimized.

Copy link
Contributor

benclifford commented May 21, 2018

This appears to have been unwound in 49d9594

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.