New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No blocks provisioned if parallelism/blocks = 0 #97

Closed
kylechard opened this Issue Feb 13, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@kylechard
Collaborator

kylechard commented Feb 13, 2018

If I set initBlocks=0 and parallelism=0 I don't think any blocks will be provisioned. I tested and the script makes no progress. Perhaps we should catch this case and present an error to users.

@yadudoc yadudoc self-assigned this Feb 13, 2018

@yadudoc yadudoc added the bug label Feb 13, 2018

@yadudoc yadudoc added this to the Parsl-0.5.0 milestone Feb 13, 2018

@yadudoc

This comment has been minimized.

Contributor

yadudoc commented Feb 13, 2018

This is a bug, I'm working on this.

yadudoc added a commit that referenced this issue Feb 13, 2018

Fixes for issue #97 where blocks are not provisioned when p==0
Adds a new case in strategy to check when slots=0 and tasks>0.
Test confirming the correct behavior.
@yadudoc

This comment has been minimized.

Contributor

yadudoc commented Feb 13, 2018

This is fixed, and will be going into 0.4.1.

@yadudoc yadudoc closed this Feb 14, 2018

yadudoc added a commit that referenced this issue Feb 23, 2018

Bumping version from 0.4.0 to 0.4.1
Several fixes included as part of this point release:
* Cobalt provider issues with job state #101
* Parsl updates config inadvertently #98
* No blocks provisioned if parallelism/blocks = 0 #97
* Checkpoint restart assumes rundir bug #95
* Logger continues after cleanup called enhancement #93
* Error checkpointing when no cache enabled  #92
* Several fixes to libsubmit.

New Providers:
* GoogleCloud
* GridEngine
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment