Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exports displayed as popup #71

Merged
merged 4 commits into from Jul 6, 2017

Conversation

@treyssatvincent
Copy link
Contributor

commented Jul 6, 2017

screenshot from 2017-07-06 15-57-48
screenshot from 2017-07-06 15-57-54
screenshot from 2017-07-06 15-58-00
screenshot from 2017-07-06 15-58-05

Pour faciliter : #68

@farlistener

This comment has been minimized.

Copy link
Collaborator

commented Jul 6, 2017

Alors je ne vais pas intégrer ce commit :

  • je ne vois pas la notion d'appel au contenu au moment de l'ouverture de la page (alors que là j'ai l'impression que le rendu est fait à l'ouverture de la page)
  • tu utilises du JS de base alors que l'application s'appuie sur du jquery (et je veux de la cohérence)
@treyssatvincent

This comment has been minimized.

Copy link
Contributor Author

commented Jul 6, 2017

le rendu est fait à l'ouverture de la page

En effet, je regarde comment corriger ça.

tu utilises du JS de base alors que l'application

Ok, je vais chercher l’équivalent en jquery.

@farlistener

This comment has been minimized.

Copy link
Collaborator

commented Jul 6, 2017

Merci 😸

Nino TREYSSAT-VINCENT added some commits Jul 6, 2017

@treyssatvincent

This comment has been minimized.

Copy link
Contributor Author

commented Jul 6, 2017

Je pense que c'est bon 😄, dis moi si j'ai utilisé du javascript pure plutôt que du jquery.

@farlistener farlistener merged commit 40bc4e9 into PartiPirate:master Jul 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.