Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions in recoverability policy do not trigger critical error #292

Merged
merged 1 commit into from Apr 17, 2019

Conversation

Projects
None yet
3 participants
@andreasohlund
Copy link
Member

commented Apr 12, 2019

Who's affected

Anyone using the transport.

Symptoms

Exceptions thrown in recoverability policy are not propagated as critical error and hide the underlying infrastructure problems that user code could be responding to.

Description

By not properly handling exceptions when the recoverability policy throws, and not raising a critical error, the transport does not allow taking an action when the underlying messaging infrastructure is partially failing. Unnecessary logging clutters the log files with exception information already logged by recoverability in Core. Log level warn downplays the significance of the accident, masquerading transport errors.

@andreasohlund andreasohlund requested review from boblangley and SeanFeldman Apr 12, 2019

@andreasohlund andreasohlund changed the title [WIP] Hotfix 4.3.1 Hotfix 4.3.1 Apr 12, 2019

@andreasohlund andreasohlund force-pushed the hotfix-4.3.1 branch from f5ac038 to 22d7ad4 Apr 12, 2019

@boblangley boblangley changed the title Hotfix 4.3.1 [WIP] Hotfix 4.3.1 Apr 12, 2019

@andreasohlund andreasohlund changed the title [WIP] Hotfix 4.3.1 Hotfix 4.3.1 Apr 15, 2019

@andreasohlund andreasohlund changed the title Hotfix 4.3.1 [WIP]Hotfix 4.3.1 Apr 15, 2019

@andreasohlund andreasohlund changed the title [WIP]Hotfix 4.3.1 Hotfix 4.3.1 Apr 16, 2019

@andreasohlund

This comment has been minimized.

Copy link
Member Author

commented Apr 16, 2019

@boblangley @SeanFeldman this one is ready to go

Invoke critical error if recoverability fails
Raise critical error when onError fails

Fix comment

Use core beta

@andreasohlund andreasohlund force-pushed the hotfix-4.3.1 branch from d43841c to 35319ff Apr 16, 2019

@andreasohlund andreasohlund added the bug label Apr 16, 2019

@andreasohlund andreasohlund merged commit 6cfd701 into master Apr 17, 2019

6 checks passed

Compile Finished TeamCity Build NServiceBus / Transports / NServiceBus.AmazonSQS / 1. Compile : Running
Details
Inspections Finished TeamCity Build NServiceBus / Transports / NServiceBus.AmazonSQS / 2. Inspections : Running
Details
Test .NET Core on Linux Finished TeamCity Build NServiceBus / Transports / NServiceBus.AmazonSQS / 3.3 Test (.NET Core on Linux) : Tests passed: 193, ignored: 54
Details
Test .NET Core on Windows Finished TeamCity Build NServiceBus / Transports / NServiceBus.AmazonSQS / 3.2 Tests (.NET Core on Windows) : Tests passed: 193, ignored: 54
Details
Test .NET Framework on Windows Finished TeamCity Build NServiceBus / Transports / NServiceBus.AmazonSQS / 3.1 Test (.NET Framework on Windows) : Tests passed: 194, ignor…
Details
WIP Ready for review
Details

@andreasohlund andreasohlund added this to the 4.3.1 milestone Apr 17, 2019

@andreasohlund andreasohlund deleted the hotfix-4.3.1 branch Apr 17, 2019

@boblangley boblangley changed the title Hotfix 4.3.1 Exceptions in recoverability policy do not trigger critical error Apr 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.