Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions in recoverability policy do not trigger critical error #293

Merged
merged 4 commits into from Apr 17, 2019

Conversation

Projects
None yet
4 participants
@andreasohlund
Copy link
Member

commented Apr 15, 2019

Who's affected

Anyone using the transport.

Symptoms

Exceptions thrown in recoverability policy are not propagated as critical error and hide the underlying infrastructure problems that user code could be responding to.

Description

By not properly handling exceptions when the recoverability policy throws, and not raising a critical error, the transport does not allow taking an action when the underlying messaging infrastructure is partially failing. Unnecessary logging clutters the log files with exception information already logged by recoverability in Core. Log level warn downplays the significance of the accident, masquerading transport errors.

Invoke critical error if recoverability fails
Raise critical error when onError fails

Fix comment

Update NServiceBus.AmazonSQS.TransportTests.csproj

Make it compile

@andreasohlund andreasohlund changed the title Invoke critical error if recoverability fails Hotfix 3.3.4 Apr 15, 2019

@andreasohlund andreasohlund added this to the 3.3.4 milestone Apr 15, 2019

@andreasohlund andreasohlund added the bug label Apr 15, 2019

@@ -5,7 +5,7 @@
<AssemblyName>NServiceBus.AmazonSQS</AssemblyName>
<SignAssembly>true</SignAssembly>
<AssemblyOriginatorKeyFile>$(SolutionDir)NServiceBus.snk</AssemblyOriginatorKeyFile>
<NoWarn>CS0419</NoWarn>
<NoWarn>CS0419;NU5125</NoWarn>

This comment has been minimized.

Copy link
@andreasohlund

andreasohlund Apr 15, 2019

Author Member

@bording I thought this shouldn't be needed after you going through all the repos? (What am I doing wrong, builds fine locally btw)

This comment has been minimized.

Copy link
@bording

bording Apr 15, 2019

Member

It should have been <NoWarn>$(NoWarn);CS0419</NoWarn> to not overwrite values being set elsewhere (from Particular.Packaging, for example), but it doesn't look like it's needed at all, so I've just removed it entirely instead.

bording and others added some commits Apr 15, 2019

@andreasohlund andreasohlund requested review from SeanFeldman and boblangley Apr 16, 2019

@andreasohlund andreasohlund merged commit 670de58 into support-3.3 Apr 17, 2019

6 checks passed

Compile Finished TeamCity Build NServiceBus / Transports / NServiceBus.AmazonSQS / 1. Compile : Running
Details
Inspections Finished TeamCity Build NServiceBus / Transports / NServiceBus.AmazonSQS / 2. Inspections : Running
Details
Test .NET Core on Linux Finished TeamCity Build NServiceBus / Transports / NServiceBus.AmazonSQS / 3.3 Test (.NET Core on Linux) : Running
Details
Test .NET Core on Windows Finished TeamCity Build NServiceBus / Transports / NServiceBus.AmazonSQS / 3.2 Tests (.NET Core on Windows) : Running
Details
Test .NET Framework on Windows Finished TeamCity Build NServiceBus / Transports / NServiceBus.AmazonSQS / 3.1 Test (.NET Framework on Windows) : Tests passed: 190, ignor…
Details
WIP Ready for review
Details

@andreasohlund andreasohlund deleted the hotfix-3.3.4 branch Apr 17, 2019

@boblangley boblangley changed the title Hotfix 3.3.4 Exceptions in recoverability policy do not trigger critical error Apr 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.