ASB transaction support #237
Conversation
src/NServiceBus.AzureFunctions.InProcess.ServiceBus/FunctionEndpoint.cs
Outdated
Show resolved
Hide resolved
src/NServiceBus.AzureFunctions.InProcess.ServiceBus/IFunctionEndpoint.cs
Outdated
Show resolved
Hide resolved
src/NServiceBus.AzureFunctions.InProcess.ServiceBus/FunctionEndpoint.cs
Outdated
Show resolved
Hide resolved
…ticular/NServiceBus.AzureFunctions.InProcess.ServiceBus into extract-transaction-strategy
Extract transaction strategy
* locate attribute to read AutoComplete value * rename public APIs * remove obsolete method usage * extract reflection code into helper * add more details to the reflection helper exception message * merge AttributeDiscoverer and ReflectionHelper methods
src/NServiceBus.AzureFunctions.SourceGenerator/TriggerFunctionGenerator2.cs
Outdated
Show resolved
Hide resolved
| // 3rd parameter might be trigger function name | ||
| triggerFunctionName = attributeParametersCount == 3 | ||
| ? AttributeParameterAtPosition(2) | ||
| : $"NServiceBusFunctionEndpointTrigger-{endpointName}"; |
There was a problem hiding this comment.
Should this be extracted as a helper method? It gets referenced above too.
There was a problem hiding this comment.
it doesn't look like we need to recompute the value here at all and can just use the initial value instead.
| : "await endpoint.ProcessNonTransactional(message, executionContext, messageReceiver, logger);")} | ||
| }} | ||
| }}"; | ||
| context.AddSource("NServiceBus__FunctionEndpointTrigger", SourceText.From(source, Encoding.UTF8)); |
There was a problem hiding this comment.
Is it OK to use the same hintname for both generators?
| var property = typeof(Message).GetProperty("SystemProperties"); | ||
| property.SetValue(asbMessage, systemProperties); | ||
|
|
||
| asbMessage.MessageId = Guid.NewGuid().ToString("N"); |
There was a problem hiding this comment.
I don't think every message is guaranteed to have a MessageId. I noticed some code failures in one of the branches because we were missing this, and I think we have to be able to cope without it for native integrations.
There was a problem hiding this comment.
this is currently needed for some of the recoverability tests to ensure we can identify the message across retries as by default we generate new IDs each time a message without an ID is received ( see the implementation of GetMessageId)
src/NServiceBus.AzureFunctions.InProcess.ServiceBus/NServiceBusTriggerFunctionAttribute.cs
Outdated
Show resolved
Hide resolved
src/NServiceBus.AzureFunctions.InProcess.ServiceBus/NServiceBusTriggerFunctionAttribute.cs
Outdated
Show resolved
Hide resolved
src/NServiceBus.AzureFunctions.InProcess.ServiceBus/FunctionEndpoint.cs
Outdated
Show resolved
Hide resolved
…sTriggerFunctionAttribute.cs Co-authored-by: Mike Minutillo <mike.minutillo@particular.net>
# Conflicts: # src/NServiceBus.AzureFunctions.InProcess.ServiceBus/ServiceBusTriggeredEndpointConfiguration.cs
Resolves #43
Based on #68.
Adds support for transactional message processing