Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions in recoverability policy do not trigger critical error #819

Merged
merged 4 commits into from Apr 18, 2019

Conversation

Projects
None yet
2 participants
@boblangley
Copy link
Member

commented Apr 17, 2019

Backport of fix from #818

Who's affected

Anyone using the transport.

Symptoms

Exceptions thrown in recoverability policy are not propagated as critical error and hide the underlying infrastructure problems that user code could be responding to.

Description

By not properly handling exceptions when the recoverability policy throws, and not raising a critical error, the transport does not allow taking an action when the underlying messaging infrastructure is partially failing.

@boblangley boblangley added the Bug label Apr 17, 2019

@boblangley boblangley added this to the 8.0.8 milestone Apr 17, 2019

@boblangley boblangley self-assigned this Apr 17, 2019

@boblangley boblangley force-pushed the hotfix-8.0.8 branch from d1b3773 to b94a36a Apr 17, 2019

@andreasohlund

This comment has been minimized.

Copy link
Member

commented Apr 17, 2019

Same failing test as the v9 PR so something seems to be broken?

@boblangley boblangley force-pushed the hotfix-8.0.8 branch from c65b7ba to 92ea7e6 Apr 17, 2019

@boblangley

This comment has been minimized.

Copy link
Member Author

commented Apr 17, 2019

CriticalError wasn't raising the error since no endpoints were registered in the test, and there is no way for the test to do so, which means the the change to pass CriticalError isn't testable. I reverted to passing around an Action, but added the string generic argument so we can set the critical error message.

@boblangley boblangley changed the title [WIP] Hotfix 8.0.8 Exceptions in recoverability policy do not trigger critical error Apr 17, 2019

@andreasohlund andreasohlund changed the title Exceptions in recoverability policy do not trigger critical error Hotfix 8.0.8 Apr 18, 2019

@andreasohlund andreasohlund changed the title Hotfix 8.0.8 Exceptions in recoverability policy do not trigger critical error Apr 18, 2019

@andreasohlund andreasohlund merged commit f56ef29 into support-8.0 Apr 18, 2019

4 checks passed

Compile Finished TeamCity Build NServiceBus / Transports / NServiceBus.AzureServiceBus / 1. Compile : Running
Details
Inspections Finished TeamCity Build NServiceBus / Transports / NServiceBus.AzureServiceBus / 2. Inspections : Running
Details
Test .NET Framework on Windows Finished TeamCity Build NServiceBus / Transports / NServiceBus.AzureServiceBus / 3.1.3 Test (.NET Framework on Windows) - MigrationTopolog…
Details
WIP Ready for review
Details

@andreasohlund andreasohlund deleted the hotfix-8.0.8 branch Apr 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.