Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions in recoverability policy do not trigger critical error #820

Merged
merged 3 commits into from Apr 18, 2019

Conversation

Projects
None yet
3 participants
@boblangley
Copy link
Member

commented Apr 17, 2019

Backport of fix from #818

Who's affected

Anyone using the transport.

Symptoms

Exceptions thrown in recoverability policy are not propagated as critical error and hide the underlying infrastructure problems that user code could be responding to.

Description

By not properly handling exceptions when the recoverability policy throws, and not raising a critical error, the transport does not allow taking an action when the underlying messaging infrastructure is partially failing.

@boblangley boblangley changed the base branch from develop to support-7.2 Apr 17, 2019

@boblangley boblangley self-assigned this Apr 17, 2019

@boblangley boblangley added the Bug label Apr 17, 2019

@boblangley boblangley added this to the 7.2.17 milestone Apr 17, 2019

@boblangley boblangley force-pushed the hotfix-7.2.17 branch from 4bb3305 to dd01652 Apr 17, 2019

@andreasohlund

This comment has been minimized.

Copy link
Member

commented Apr 17, 2019

Test fails with

System.ApplicationException : Could not build NServiceBus.CriticalError
----> System.Exception : Failed to build type: NServiceBus.CriticalError
----> System.MissingMethodException : No parameterless constructor defined for this object.
at NServiceBus.Transport.AzureServiceBus.TransportPartsContainer.ResolveT in C:\BuildAgent\work\a0340fa70aa3bd40\src\Transport\Utils\TransportPartsContainer.cs:line 104

@boblangley boblangley changed the title [WIP] Hotfix 7.2.17 Exceptions in recoverability policy do not trigger critical error Apr 17, 2019

@andreasohlund

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

Raised #822 to try to fix the issue with resolving the critical error. Thoughts?

@boblangley boblangley requested a review from SeanFeldman Apr 18, 2019

@boblangley

This comment has been minimized.

Copy link
Member Author

commented Apr 18, 2019

I merged your PR, and our tests are green. @SeanFeldman can you review and merge?

@SeanFeldman SeanFeldman merged commit 5763dbe into support-7.2 Apr 18, 2019

4 checks passed

Compile Finished TeamCity Build NServiceBus / Transports / NServiceBus.AzureServiceBus / 1. Compile : Running
Details
Inspections Finished TeamCity Build NServiceBus / Transports / NServiceBus.AzureServiceBus / 2. Inspections : Running
Details
Test .NET Framework on Windows Finished TeamCity Build NServiceBus / Transports / NServiceBus.AzureServiceBus / 3.1.3 Test (.NET Framework on Windows) - MigrationTopolog…
Details
WIP Ready for review
Details

@SeanFeldman SeanFeldman deleted the hotfix-7.2.17 branch Apr 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.