Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions in recoverability policy do not trigger critical error #362

Closed
SeanFeldman opened this issue Apr 16, 2019 · 1 comment

Comments

Projects
None yet
1 participant
@SeanFeldman
Copy link
Contributor

commented Apr 16, 2019

Who's affected

Anyone using the transport.

Symptoms

Exceptions thrown in recoverability policy are not propagated as critical error and hide the underlying infrastructure problems that user code could be responding to.

Description

By not properly handling exceptions when the recoverability policy throws, and not raising a critical error, the transport does not allow taking an action when the underlying messaging infrastructure is partially failing. Unnecessary logging clutters the log files with exception information already logged by recoverability in Core. Log level warn downplays the significance of the accident, masquerading transport errors.

@SeanFeldman SeanFeldman added the Bug label Apr 16, 2019

@SeanFeldman SeanFeldman added this to the 7.5.7 milestone Apr 16, 2019

SeanFeldman added a commit that referenced this issue Apr 16, 2019

@SeanFeldman

This comment has been minimized.

Copy link
Contributor Author

commented Apr 17, 2019

Fixed via 1add910

@SeanFeldman SeanFeldman changed the title Align transport behavior when an exception is thrown in the recoverability policy Exceptions in recoverability policy do not trigger critical error Apr 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.