Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shutdown of endpoint can hang until ServiceControlReportingInterval is reached #61

Open
danielmarbach opened this issue Jul 1, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@danielmarbach
Copy link
Member

commented Jul 1, 2019

Raised based on https://discuss.particular.net/t/shutdown-of-services-takes-a-long-time-with-servicecontrol-metrics-plugin-enabled/

Who's affected

All customers using SendMetricDataToServiceControl

Symptoms

When an endpoint is stopped the endpoint stop can be delayed until ServiceControlReportingInterval is reached

Analysis

The loop sending data to ServiceControl does not take the cancellation token into account, see
https://github.com/Particular/NServiceBus.Metrics.ServiceControl/blob/master/src/NServiceBus.Metrics.ServiceControl/ReportingFeature.cs#L188-L189

@danielmarbach danielmarbach added the bug label Jul 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.