Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add indexes on all collection items not only with Id properties #350

Merged
merged 2 commits into from Jul 12, 2019

Conversation

@ramonsmits
Copy link
Member

commented Nov 13, 2018

Overview

This PR changes the saga data script generation. It makes sure that for child collections that do not specify an id property a unique index gets created on foreign key column pointing to the master table.

The resulting script was tested on Ms SQL and Oracle 19c.

Old content Based on a support case and [issue comment](https://github.com//issues/297#issuecomment-434366580) where a customer expected to see indexes on the FK for a child collection. Not having indexes created is likely to result in deadlocks because of table locks on the child collection table on Oracle and MSSQL.

Not heavily tested! Might need some additional test scenarios!

@ramonsmits ramonsmits force-pushed the index-on-collection-items-without-id branch from 2df86f9 to 3bfcfa6 Nov 13, 2018

@andreasohlund andreasohlund changed the base branch from develop to master Jun 18, 2019

@tmasternak tmasternak force-pushed the index-on-collection-items-without-id branch from 3bfcfa6 to 073edcc Jul 12, 2019

@tmasternak tmasternak requested a review from DavidBoike Jul 12, 2019

@tmasternak tmasternak changed the title WIP: Add indexes on all collection items not only with Id properties Add indexes on all collection items not only with Id properties Jul 12, 2019

@tmasternak

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

@DavidBoike fyi. For some reason, github is not showing the newest build status. All are green.

@DavidBoike DavidBoike merged commit 65ad378 into master Jul 12, 2019

2 checks passed

WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@DavidBoike DavidBoike deleted the index-on-collection-items-without-id branch Jul 12, 2019

@DavidBoike

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

I think it's because this PR is so old that TC was evaluating it as 350 instead of pull/350/merge and thus not reporting back at all. I moved the branch protection aside (I'm a GH admin) merged, and then restored the protections.

@WilliamBZA WilliamBZA added this to the 8.2.0 milestone Jul 26, 2019

@WilliamBZA WilliamBZA added the Bug label Jul 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.